Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 667983005: Rename mojo_html_viewer target to just html_viewer. (Closed)

Created:
6 years, 2 months ago by Aaron Boodman
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename mojo_html_viewer target to just html_viewer. We want the resulting library to be named without the mojo_ prefix and there doesn't appear to control the output name in gyp. Committed: https://crrev.com/7b0479aaf40d371abd0433d287d56d47d91197fa Cr-Commit-Position: refs/heads/master@{#300822}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unnecessary output_name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M mojo/mojo.gyp View 2 chunks +1 line, -1 line 0 comments Download
M mojo/mojo_services.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Aaron Boodman
6 years, 2 months ago (2014-10-21 23:12:03 UTC) #2
jamesr
lgtm https://codereview.chromium.org/667983005/diff/1/mojo/services/html_viewer/BUILD.gn File mojo/services/html_viewer/BUILD.gn (right): https://codereview.chromium.org/667983005/diff/1/mojo/services/html_viewer/BUILD.gn#newcode7 mojo/services/html_viewer/BUILD.gn:7: output_name = "html_viewer" you can just remove this ...
6 years, 2 months ago (2014-10-21 23:15:03 UTC) #3
Aaron Boodman
Good point, done.
6 years, 2 months ago (2014-10-21 23:17:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667983005/20001
6 years, 2 months ago (2014-10-23 01:30:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 02:22:35 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 02:23:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b0479aaf40d371abd0433d287d56d47d91197fa
Cr-Commit-Position: refs/heads/master@{#300822}

Powered by Google App Engine
This is Rietveld 408576698