tools/dom/scripts/htmldartgenerator.py - Issue 667983002: Arity indexing in dart:blink entry points

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 667983002: Arity indexing in dart:blink entry points (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/htmldartgenerator.py

diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py

index 9cc4124d0783b148d04642c5ad774de973f45db7..6699fd3ca366136b15f2c001b540bc9fa9c890dc 100644

--- a/tools/dom/scripts/htmldartgenerator.py

+++ b/tools/dom/scripts/htmldartgenerator.py

@@ -475,7 +475,7 @@ class HtmlDartGenerator(object):

version, operations[signature_index], argument_count)

def IsOptional(signature_index, argument):

- return is_optional(operations[signature_index], argument)

+ return is_optional(argument)

emitter = self._members_emitter

@@ -589,8 +589,7 @@ class HtmlDartGenerator(object):

if self._dart_use_blink:

type_ids = [p.type.id for p in arguments]

base_name, rs = \

- self.DeriveNativeEntry("constructorCallback", None, type_ids,

- False)

+ self.DeriveNativeEntry("constructorCallback", 'Constructor', argument_count)

qualified_name = \

self.DeriveQualifiedBlinkName(self._interface.id,

base_name)

« no previous file with comments | « tools/dom/scripts/css_code_generator.py ('k') | tools/dom/scripts/systemhtml.py » ('j') | no next file with comments »