content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_cache_storage.cc ('k') | content/browser/service_worker/service_worker_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

diff --git a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

index b82774a37974bc7e2eec6d097ebd5b7bd22d63e9..09d3537dadc20bbe63d83bc721071531309c3c84 100644

--- a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

+++ b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

@@ -223,13 +223,13 @@ class ServiceWorkerCacheStorageManagerTest : public testing::Test {

class ServiceWorkerCacheStorageManagerMemoryOnlyTest

: public ServiceWorkerCacheStorageManagerTest {

- virtual bool MemoryOnly() override { return true; }

+ bool MemoryOnly() override { return true; }

};

class ServiceWorkerCacheStorageManagerTestP

: public ServiceWorkerCacheStorageManagerTest,

public testing::WithParamInterface<bool> {

- virtual bool MemoryOnly() override { return !GetParam(); }

+ bool MemoryOnly() override { return !GetParam(); }

};

TEST_F(ServiceWorkerCacheStorageManagerTest, TestsRunOnIOThread) {

@@ -515,7 +515,7 @@ class ServiceWorkerCacheQuotaClientTest

class ServiceWorkerCacheQuotaClientTestP

: public ServiceWorkerCacheQuotaClientTest,

public testing::WithParamInterface<bool> {

- virtual bool MemoryOnly() override { return !GetParam(); }

+ bool MemoryOnly() override { return !GetParam(); }

};

TEST_P(ServiceWorkerCacheQuotaClientTestP, QuotaID) {