content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/screen_orientation/screen_orientation_browsertest.cc ('k') | content/browser/security_exploit_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h

diff --git a/content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h b/content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h

index c22d65bd3556e79af9dc7dc9a2839363d49d53a7..a88408378837f4fc87ec3035f40deb85b4470fbd 100644

--- a/content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h

+++ b/content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h

@@ -24,19 +24,19 @@ class CONTENT_EXPORT ScreenOrientationDispatcherHostImpl

public WebContentsObserver {

public:

explicit ScreenOrientationDispatcherHostImpl(WebContents* web_contents);

- virtual ~ScreenOrientationDispatcherHostImpl();

+ ~ScreenOrientationDispatcherHostImpl() override;

// ScreenOrientationDispatcherHost:

- virtual void NotifyLockSuccess(int request_id) override;

- virtual void NotifyLockError(int request_id,

- blink::WebLockOrientationError error) override;

- virtual void OnOrientationChange() override;

+ void NotifyLockSuccess(int request_id) override;

+ void NotifyLockError(int request_id,

+ blink::WebLockOrientationError error) override;

+ void OnOrientationChange() override;

// WebContentsObserver:

- virtual bool OnMessageReceived(const IPC::Message&,

- RenderFrameHost* render_frame_host) override;

- virtual void DidNavigateMainFrame(const LoadCommittedDetails& details,

- const FrameNavigateParams& params) override;

+ bool OnMessageReceived(const IPC::Message&,

+ RenderFrameHost* render_frame_host) override;

+ void DidNavigateMainFrame(const LoadCommittedDetails& details,

+ const FrameNavigateParams& params) override;

private:

void OnLockRequest(RenderFrameHost* render_frame_host,