content/browser/renderer_host/socket_stream_host.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/socket_stream_host.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/socket_stream_dispatcher_host.h ('k') | content/browser/renderer_host/socket_stream_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/socket_stream_host.h

diff --git a/content/browser/renderer_host/socket_stream_host.h b/content/browser/renderer_host/socket_stream_host.h

index 73e8f72c07f1d52fa39d05c1a28e9ed587856a87..94234fb1813b42725a164ecb371bfea19e6befc0 100644

--- a/content/browser/renderer_host/socket_stream_host.h

+++ b/content/browser/renderer_host/socket_stream_host.h

@@ -34,7 +34,7 @@ class SocketStreamHost : public SSLErrorHandler::Delegate {

int child_id,

int render_frame_id,

int socket_id);

- virtual ~SocketStreamHost();

+ ~SocketStreamHost() override;

// Gets socket_id associated with |socket|.

static int SocketIdFromSocketStream(const net::SocketStream* socket);

@@ -58,9 +58,8 @@ class SocketStreamHost : public SSLErrorHandler::Delegate {

base::WeakPtr<SSLErrorHandler::Delegate> AsSSLErrorHandlerDelegate();

// SSLErrorHandler::Delegate methods:

- virtual void CancelSSLRequest(int error,

- const net::SSLInfo* ssl_info) override;

- virtual void ContinueSSLRequest() override;

+ void CancelSSLRequest(int error, const net::SSLInfo* ssl_info) override;

+ void ContinueSSLRequest() override;

private:

net::SocketStream::Delegate* delegate_;