Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: content/browser/plugin_browsertest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/pepper_flash_settings_helper_impl.h ('k') | content/browser/plugin_data_remover_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_browsertest.cc
diff --git a/content/browser/plugin_browsertest.cc b/content/browser/plugin_browsertest.cc
index 8caf7eaa4e0b68a6395b2a23b92a4c73c5dd2a67..a5ca6da74eae64a34cc7357821296a487641a9f7 100644
--- a/content/browser/plugin_browsertest.cc
+++ b/content/browser/plugin_browsertest.cc
@@ -49,7 +49,7 @@ class PluginTest : public ContentBrowserTest {
protected:
PluginTest() {}
- virtual void SetUpCommandLine(CommandLine* command_line) override {
+ void SetUpCommandLine(CommandLine* command_line) override {
// Some NPAPI tests schedule garbage collection to force object tear-down.
command_line->AppendSwitchASCII(switches::kJavaScriptFlags, "--expose_gc");
@@ -76,7 +76,7 @@ class PluginTest : public ContentBrowserTest {
#endif
}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
base::FilePath path = GetTestFilePath("", "");
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE, base::Bind(&SetUrlRequestMock, path));
@@ -508,11 +508,10 @@ class TestResourceDispatcherHostDelegate
private:
// ResourceDispatcherHostDelegate implementation:
- virtual void OnResponseStarted(
- net::URLRequest* request,
- ResourceContext* resource_context,
- ResourceResponse* response,
- IPC::Sender* sender) override {
+ void OnResponseStarted(net::URLRequest* request,
+ ResourceContext* resource_context,
+ ResourceResponse* response,
+ IPC::Sender* sender) override {
// The URL below comes from plugin_geturl_test.cc.
if (!EndsWith(request->url().spec(),
"npapi/plugin_ref_target_page.html",
« no previous file with comments | « content/browser/pepper_flash_settings_helper_impl.h ('k') | content/browser/plugin_data_remover_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698