content/browser/service_worker/service_worker_request_handler.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_request_handler.h ('k') | content/browser/service_worker/service_worker_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_request_handler.cc b/content/browser/service_worker/service_worker_request_handler.cc

index 3698eb7897c5fb61199ddb823efa5d35c8420af3..6c871e6cd55ba588518b0f856964d472c927fb2a 100644

--- a/content/browser/service_worker/service_worker_request_handler.cc

+++ b/content/browser/service_worker/service_worker_request_handler.cc

@@ -31,8 +31,8 @@ class ServiceWorkerRequestInterceptor

public:

explicit ServiceWorkerRequestInterceptor(ResourceContext* resource_context)

: resource_context_(resource_context) {}

- virtual ~ServiceWorkerRequestInterceptor() {}

- virtual net::URLRequestJob* MaybeInterceptRequest(

+ ~ServiceWorkerRequestInterceptor() override {}

+ net::URLRequestJob* MaybeInterceptRequest(

net::URLRequest* request,

net::NetworkDelegate* network_delegate) const override {

ServiceWorkerRequestHandler* handler =