content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc ('k') | content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm

diff --git a/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm b/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm

index fb4bc45677486e74f5f3ac1d8da5996afa9ccd3d..1e52e172bbfb869504e341548fc564ff464c1caa 100644

--- a/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm

+++ b/content/browser/renderer_host/pepper/pepper_truetype_font_mac.mm

@@ -98,16 +98,15 @@ class PepperTrueTypeFontMac : public PepperTrueTypeFont {

PepperTrueTypeFontMac();

// PepperTrueTypeFont implementation.

- virtual int32_t Initialize(

- ppapi::proxy::SerializedTrueTypeFontDesc* desc) override;

- virtual int32_t GetTableTags(std::vector<uint32_t>* tags) override;

- virtual int32_t GetTable(uint32_t table_tag,

- int32_t offset,

- int32_t max_data_length,

- std::string* data) override;

+ int32_t Initialize(ppapi::proxy::SerializedTrueTypeFontDesc* desc) override;

+ int32_t GetTableTags(std::vector<uint32_t>* tags) override;

+ int32_t GetTable(uint32_t table_tag,

+ int32_t offset,

+ int32_t max_data_length,

+ std::string* data) override;

private:

- virtual ~PepperTrueTypeFontMac() override;

+ ~PepperTrueTypeFontMac() override;

virtual int32_t GetEntireFont(int32_t offset,

int32_t max_data_length,