Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: content/browser/loader/detachable_resource_handler.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/detachable_resource_handler.h
diff --git a/content/browser/loader/detachable_resource_handler.h b/content/browser/loader/detachable_resource_handler.h
index ecacae0b76e06094846a696dfb0fb4e061d3de11..64d23ef2628e2fe27aaacf5275c594586f48514d 100644
--- a/content/browser/loader/detachable_resource_handler.h
+++ b/content/browser/loader/detachable_resource_handler.h
@@ -37,7 +37,7 @@ class DetachableResourceHandler : public ResourceHandler,
DetachableResourceHandler(net::URLRequest* request,
base::TimeDelta cancel_delay,
scoped_ptr<ResourceHandler> next_handler);
- virtual ~DetachableResourceHandler();
+ ~DetachableResourceHandler() override;
bool is_detached() const { return next_handler_ == NULL; }
void Detach();
@@ -47,29 +47,28 @@ class DetachableResourceHandler : public ResourceHandler,
}
// ResourceHandler implementation:
- virtual void SetController(ResourceController* controller) override;
- virtual bool OnUploadProgress(uint64 position, uint64 size) override;
- virtual bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
- ResourceResponse* response,
- bool* defer) override;
- virtual bool OnResponseStarted(ResourceResponse* response,
- bool* defer) override;
- virtual bool OnWillStart(const GURL& url, bool* defer) override;
- virtual bool OnBeforeNetworkStart(const GURL& url, bool* defer) override;
- virtual bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
- int* buf_size,
- int min_size) override;
- virtual bool OnReadCompleted(int bytes_read, bool* defer) override;
- virtual void OnResponseCompleted(const net::URLRequestStatus& status,
- const std::string& security_info,
- bool* defer) override;
- virtual void OnDataDownloaded(int bytes_downloaded) override;
+ void SetController(ResourceController* controller) override;
+ bool OnUploadProgress(uint64 position, uint64 size) override;
+ bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
+ ResourceResponse* response,
+ bool* defer) override;
+ bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
+ bool OnWillStart(const GURL& url, bool* defer) override;
+ bool OnBeforeNetworkStart(const GURL& url, bool* defer) override;
+ bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
+ int* buf_size,
+ int min_size) override;
+ bool OnReadCompleted(int bytes_read, bool* defer) override;
+ void OnResponseCompleted(const net::URLRequestStatus& status,
+ const std::string& security_info,
+ bool* defer) override;
+ void OnDataDownloaded(int bytes_downloaded) override;
// ResourceController implementation:
- virtual void Resume() override;
- virtual void Cancel() override;
- virtual void CancelAndIgnore() override;
- virtual void CancelWithError(int error_code) override;
+ void Resume() override;
+ void Cancel() override;
+ void CancelAndIgnore() override;
+ void CancelWithError(int error_code) override;
private:
scoped_ptr<ResourceHandler> next_handler_;
« no previous file with comments | « content/browser/loader/cross_site_resource_handler.h ('k') | content/browser/loader/layered_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698