content/browser/device_sensors/data_fetcher_shared_memory_base.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_base.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_sensors/data_fetcher_shared_memory.h ('k') | content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/data_fetcher_shared_memory_base.cc

diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_base.cc b/content/browser/device_sensors/data_fetcher_shared_memory_base.cc

index c868429a8fe6218b498fbdaf1c968eba8e4db53b..d997537c059157e70dbc01974cb6def5e9d2b5a0 100644

--- a/content/browser/device_sensors/data_fetcher_shared_memory_base.cc

+++ b/content/browser/device_sensors/data_fetcher_shared_memory_base.cc

@@ -36,7 +36,7 @@ static size_t GetConsumerSharedMemoryBufferSize(ConsumerType consumer_type) {

class DataFetcherSharedMemoryBase::PollingThread : public base::Thread {

public:

PollingThread(const char* name, DataFetcherSharedMemoryBase* fetcher);

- virtual ~PollingThread();

+ ~PollingThread() override;

void AddConsumer(ConsumerType consumer_type, void* buffer);

void RemoveConsumer(ConsumerType consumer_type);