Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: content/browser/appcache/appcache_url_request_job.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_url_request_job.h
diff --git a/content/browser/appcache/appcache_url_request_job.h b/content/browser/appcache/appcache_url_request_job.h
index e3c087110f05f09fa4be0f83c13761bafc83c1f3..580b86a58a2a456fc296e8d6756e42306ad46e47 100644
--- a/content/browser/appcache/appcache_url_request_job.h
+++ b/content/browser/appcache/appcache_url_request_job.h
@@ -72,7 +72,7 @@ class CONTENT_EXPORT AppCacheURLRequestJob
// net::URLRequestJob's Kill method is made public so the users of this
// class in the appcache namespace can call it.
- virtual void Kill() override;
+ void Kill() override;
// Returns true if the job has been started by the net library.
bool has_been_started() const {
@@ -90,7 +90,7 @@ class CONTENT_EXPORT AppCacheURLRequestJob
}
protected:
- virtual ~AppCacheURLRequestJob();
+ ~AppCacheURLRequestJob() override;
private:
friend class content::AppCacheRequestHandlerTest;
@@ -120,9 +120,9 @@ class CONTENT_EXPORT AppCacheURLRequestJob
void BeginErrorDelivery(const char* message);
// AppCacheStorage::Delegate methods
- virtual void OnResponseInfoLoaded(
- AppCacheResponseInfo* response_info, int64 response_id) override;
- virtual void OnCacheLoaded(AppCache* cache, int64 cache_id) override;
+ void OnResponseInfoLoaded(AppCacheResponseInfo* response_info,
+ int64 response_id) override;
+ void OnCacheLoaded(AppCache* cache, int64 cache_id) override;
const net::HttpResponseInfo* http_info() const;
bool is_range_request() const { return range_requested_.IsValid(); }
@@ -132,22 +132,19 @@ class CONTENT_EXPORT AppCacheURLRequestJob
void OnReadComplete(int result);
// net::URLRequestJob methods, see url_request_job.h for doc comments
- virtual void Start() override;
- virtual net::LoadState GetLoadState() const override;
- virtual bool GetCharset(std::string* charset) override;
- virtual void GetResponseInfo(net::HttpResponseInfo* info) override;
- virtual bool ReadRawData(net::IOBuffer* buf,
- int buf_size,
- int *bytes_read) override;
+ void Start() override;
+ net::LoadState GetLoadState() const override;
+ bool GetCharset(std::string* charset) override;
+ void GetResponseInfo(net::HttpResponseInfo* info) override;
+ bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;
// Sets extra request headers for Job types that support request headers.
// This is how we get informed of range-requests.
- virtual void SetExtraRequestHeaders(
- const net::HttpRequestHeaders& headers) override;
+ void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers) override;
// FilterContext methods
- virtual bool GetMimeType(std::string* mime_type) const override;
- virtual int GetResponseCode() const override;
+ bool GetMimeType(std::string* mime_type) const override;
+ int GetResponseCode() const override;
AppCacheHost* host_;
AppCacheStorage* storage_;

Powered by Google App Engine
This is Rietveld 408576698