Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: content/browser/frame_host/frame_tree_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree_unittest.cc
diff --git a/content/browser/frame_host/frame_tree_unittest.cc b/content/browser/frame_host/frame_tree_unittest.cc
index b4d41b2620cad544f94c4bb364f83d9bafaccf14..bb705c7f881adc195a656a8539e0e1a1977e5135 100644
--- a/content/browser/frame_host/frame_tree_unittest.cc
+++ b/content/browser/frame_host/frame_tree_unittest.cc
@@ -51,7 +51,7 @@ class TreeWalkingWebContentsLogger : public WebContentsObserver {
explicit TreeWalkingWebContentsLogger(WebContents* web_contents)
: WebContentsObserver(web_contents) {}
- virtual ~TreeWalkingWebContentsLogger() {
+ ~TreeWalkingWebContentsLogger() override {
EXPECT_EQ("", log_) << "Activity logged that was not expected";
}
@@ -63,22 +63,22 @@ class TreeWalkingWebContentsLogger : public WebContentsObserver {
}
// content::WebContentsObserver implementation.
- virtual void RenderFrameCreated(RenderFrameHost* render_frame_host) override {
+ void RenderFrameCreated(RenderFrameHost* render_frame_host) override {
LogWhatHappened("RenderFrameCreated", render_frame_host);
}
- virtual void RenderFrameHostChanged(RenderFrameHost* old_host,
- RenderFrameHost* new_host) override {
+ void RenderFrameHostChanged(RenderFrameHost* old_host,
+ RenderFrameHost* new_host) override {
if (old_host)
LogWhatHappened("RenderFrameChanged(old)", old_host);
LogWhatHappened("RenderFrameChanged(new)", new_host);
}
- virtual void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
+ void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
LogWhatHappened("RenderFrameDeleted", render_frame_host);
}
- virtual void RenderProcessGone(base::TerminationStatus status) override {
+ void RenderProcessGone(base::TerminationStatus status) override {
LogWhatHappened("RenderProcessGone");
}
« no previous file with comments | « content/browser/frame_host/frame_tree_browsertest.cc ('k') | content/browser/frame_host/interstitial_page_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698