content/browser/plugin_process_host.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_process_host.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/plugin_process_host.cc

diff --git a/content/browser/plugin_process_host.cc b/content/browser/plugin_process_host.cc

index c2567595aa2d4f119551589e6c134a58f3c1316e..2c10b09889b8ebd0461335627bd128e2e80c9fd6 100644

--- a/content/browser/plugin_process_host.cc

+++ b/content/browser/plugin_process_host.cc

@@ -104,7 +104,7 @@ class PluginSandboxedProcessLauncherDelegate

#endif // OS_POSIX

{}

- virtual ~PluginSandboxedProcessLauncherDelegate() {}

+ ~PluginSandboxedProcessLauncherDelegate() override {}

#if defined(OS_WIN)

virtual bool ShouldSandbox() override {

@@ -112,9 +112,7 @@ class PluginSandboxedProcessLauncherDelegate

}

#elif defined(OS_POSIX)

- virtual base::ScopedFD TakeIpcFd() override {

- return ipc_fd_.Pass();

- }

+ base::ScopedFD TakeIpcFd() override { return ipc_fd_.Pass(); }

#endif // OS_WIN

private:

« no previous file with comments | « content/browser/plugin_process_host.h ('k') | content/browser/plugin_service_impl.h » ('j') | no next file with comments »