content/browser/indexed_db/mock_indexed_db_callbacks.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/mock_indexed_db_callbacks.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc ('k') | content/browser/indexed_db/mock_indexed_db_database_callbacks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/mock_indexed_db_callbacks.h

diff --git a/content/browser/indexed_db/mock_indexed_db_callbacks.h b/content/browser/indexed_db/mock_indexed_db_callbacks.h

index 780555d6f8461923128d998fe17b2517e09d7745..24743fe0b3268fef4de802766206cce97373d8b6 100644

--- a/content/browser/indexed_db/mock_indexed_db_callbacks.h

+++ b/content/browser/indexed_db/mock_indexed_db_callbacks.h

@@ -17,16 +17,16 @@ class MockIndexedDBCallbacks : public IndexedDBCallbacks {

MockIndexedDBCallbacks();

explicit MockIndexedDBCallbacks(bool expect_connection);

- virtual void OnSuccess() override;

- virtual void OnSuccess(int64 result) override;

- virtual void OnSuccess(const std::vector<base::string16>& result) override;

- virtual void OnSuccess(const IndexedDBKey& key) override;

- virtual void OnSuccess(scoped_ptr<IndexedDBConnection> connection,

- const IndexedDBDatabaseMetadata& metadata) override;

+ void OnSuccess() override;

+ void OnSuccess(int64 result) override;

+ void OnSuccess(const std::vector<base::string16>& result) override;

+ void OnSuccess(const IndexedDBKey& key) override;

+ void OnSuccess(scoped_ptr<IndexedDBConnection> connection,

+ const IndexedDBDatabaseMetadata& metadata) override;

IndexedDBConnection* connection() { return connection_.get(); }

protected:

- virtual ~MockIndexedDBCallbacks();

+ ~MockIndexedDBCallbacks() override;

scoped_ptr<IndexedDBConnection> connection_;