Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: content/browser/service_worker/service_worker_cache.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache.cc
diff --git a/content/browser/service_worker/service_worker_cache.cc b/content/browser/service_worker/service_worker_cache.cc
index ddff117e5a5ba4d02dac8a363ee96d18f913c0c1..5026cef7f913470890fc36538efa6ea1a02d1f1b 100644
--- a/content/browser/service_worker/service_worker_cache.cc
+++ b/content/browser/service_worker/service_worker_cache.cc
@@ -113,31 +113,30 @@ class BlobReader : public net::URLRequest::Delegate {
}
// net::URLRequest::Delegate overrides for reading blobs.
- virtual void OnReceivedRedirect(net::URLRequest* request,
- const net::RedirectInfo& redirect_info,
- bool* defer_redirect) override {
+ void OnReceivedRedirect(net::URLRequest* request,
+ const net::RedirectInfo& redirect_info,
+ bool* defer_redirect) override {
NOTREACHED();
}
- virtual void OnAuthRequired(net::URLRequest* request,
- net::AuthChallengeInfo* auth_info) override {
+ void OnAuthRequired(net::URLRequest* request,
+ net::AuthChallengeInfo* auth_info) override {
NOTREACHED();
}
- virtual void OnCertificateRequested(
+ void OnCertificateRequested(
net::URLRequest* request,
net::SSLCertRequestInfo* cert_request_info) override {
NOTREACHED();
}
- virtual void OnSSLCertificateError(net::URLRequest* request,
- const net::SSLInfo& ssl_info,
- bool fatal) override {
+ void OnSSLCertificateError(net::URLRequest* request,
+ const net::SSLInfo& ssl_info,
+ bool fatal) override {
NOTREACHED();
}
- virtual void OnBeforeNetworkStart(net::URLRequest* request,
- bool* defer) override {
+ void OnBeforeNetworkStart(net::URLRequest* request, bool* defer) override {
NOTREACHED();
}
- virtual void OnResponseStarted(net::URLRequest* request) override {
+ void OnResponseStarted(net::URLRequest* request) override {
if (!request->status().is_success()) {
callback_.Run(false);
return;
@@ -153,8 +152,7 @@ class BlobReader : public net::URLRequest::Delegate {
OnReadCompleted(blob_request_.get(), bytes_read);
}
- virtual void OnReadCompleted(net::URLRequest* request,
- int bytes_read) override {
+ void OnReadCompleted(net::URLRequest* request, int bytes_read) override {
if (!request->status().is_success()) {
callback_.Run(false);
return;

Powered by Google App Engine
This is Rietveld 408576698