content/browser/geolocation/location_provider_base.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/location_provider_base.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/location_arbitrator_impl_unittest.cc ('k') | content/browser/geolocation/mock_location_arbitrator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/location_provider_base.h

diff --git a/content/browser/geolocation/location_provider_base.h b/content/browser/geolocation/location_provider_base.h

index 196dc5c5dd691c6baece2497033b6d062451fe03..1e3f4430da0d33e59b420a7174c809106983ab95 100644

--- a/content/browser/geolocation/location_provider_base.h

+++ b/content/browser/geolocation/location_provider_base.h

@@ -14,15 +14,15 @@ class CONTENT_EXPORT LocationProviderBase

: NON_EXPORTED_BASE(public LocationProvider) {

public:

LocationProviderBase();

- virtual ~LocationProviderBase();

+ ~LocationProviderBase() override;

protected:

void NotifyCallback(const Geoposition& position);

// Overridden from LocationProvider:

- virtual void SetUpdateCallback(

+ void SetUpdateCallback(

const LocationProviderUpdateCallback& callback) override;

- virtual void RequestRefresh() override;

+ void RequestRefresh() override;

private:

LocationProviderUpdateCallback callback_;