content/browser/fileapi/mock_url_request_delegate.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/mock_url_request_delegate.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/mock_file_update_observer.h ('k') | content/browser/fileapi/recursive_operation_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/mock_url_request_delegate.h

diff --git a/content/browser/fileapi/mock_url_request_delegate.h b/content/browser/fileapi/mock_url_request_delegate.h

index ef301aee8294587d3bb3da5fd55286690c1171b4..a628f6ea5a424298b3a48d0060a1f1b746963947 100644

--- a/content/browser/fileapi/mock_url_request_delegate.h

+++ b/content/browser/fileapi/mock_url_request_delegate.h

@@ -17,11 +17,10 @@ namespace content {

class MockURLRequestDelegate : public net::URLRequest::Delegate {

public:

MockURLRequestDelegate();

- virtual ~MockURLRequestDelegate();

+ ~MockURLRequestDelegate() override;

- virtual void OnResponseStarted(net::URLRequest* request) override;

- virtual void OnReadCompleted(net::URLRequest* request,

- int bytes_read) override;

+ void OnResponseStarted(net::URLRequest* request) override;

+ void OnReadCompleted(net::URLRequest* request, int bytes_read) override;

const std::string& response_data() const { return response_data_; }

private: