Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: content/browser/geolocation/geolocation_provider_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/geolocation_provider_impl.h
diff --git a/content/browser/geolocation/geolocation_provider_impl.h b/content/browser/geolocation/geolocation_provider_impl.h
index c4a29c57d15682a9bab44cc1ad57a672392a4620..b3c128649bbfcfd9f9570891e9270fd6c50568ed 100644
--- a/content/browser/geolocation/geolocation_provider_impl.h
+++ b/content/browser/geolocation/geolocation_provider_impl.h
@@ -26,11 +26,11 @@ class CONTENT_EXPORT GeolocationProviderImpl
public base::Thread {
public:
// GeolocationProvider implementation:
- virtual scoped_ptr<GeolocationProvider::Subscription>
- AddLocationUpdateCallback(const LocationUpdateCallback& callback,
- bool use_high_accuracy) override;
- virtual void UserDidOptIntoLocationServices() override;
- virtual void OverrideLocationForTesting(const Geoposition& position) override;
+ scoped_ptr<GeolocationProvider::Subscription> AddLocationUpdateCallback(
+ const LocationUpdateCallback& callback,
+ bool use_high_accuracy) override;
+ void UserDidOptIntoLocationServices() override;
+ void OverrideLocationForTesting(const Geoposition& position) override;
// Callback from the LocationArbitrator. Public for testing.
void OnLocationUpdate(const Geoposition& position);
@@ -48,7 +48,7 @@ class CONTENT_EXPORT GeolocationProviderImpl
protected:
friend struct DefaultSingletonTraits<GeolocationProviderImpl>;
GeolocationProviderImpl();
- virtual ~GeolocationProviderImpl();
+ ~GeolocationProviderImpl() override;
// Useful for injecting mock geolocation arbitrator in tests.
virtual LocationArbitrator* CreateArbitrator();
@@ -75,8 +75,8 @@ class CONTENT_EXPORT GeolocationProviderImpl
void NotifyClients(const Geoposition& position);
// Thread
- virtual void Init() override;
- virtual void CleanUp() override;
+ void Init() override;
+ void CleanUp() override;
base::CallbackList<void(const Geoposition&)> high_accuracy_callbacks_;
base::CallbackList<void(const Geoposition&)> low_accuracy_callbacks_;

Powered by Google App Engine
This is Rietveld 408576698