Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: content/browser/appcache/appcache_update_job.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_update_job.h
diff --git a/content/browser/appcache/appcache_update_job.h b/content/browser/appcache/appcache_update_job.h
index 0ccb270e08c8da170fc905f8a6ea7959ab75d0a1..4d2d896ea74485cbb2757e145de08748a547eca7 100644
--- a/content/browser/appcache/appcache_update_job.h
+++ b/content/browser/appcache/appcache_update_job.h
@@ -46,7 +46,7 @@ class CONTENT_EXPORT AppCacheUpdateJob
};
AppCacheUpdateJob(AppCacheServiceImpl* service, AppCacheGroup* group);
- virtual ~AppCacheUpdateJob();
+ ~AppCacheUpdateJob() override;
// Triggers the update process or adds more info if this update is already
// in progress.
@@ -114,7 +114,7 @@ class CONTENT_EXPORT AppCacheUpdateJob
URLFetcher(const GURL& url,
FetchType fetch_type,
AppCacheUpdateJob* job);
- virtual ~URLFetcher();
+ ~URLFetcher() override;
void Start();
FetchType fetch_type() const { return fetch_type_; }
net::URLRequest* request() const { return request_.get(); }
@@ -134,12 +134,11 @@ class CONTENT_EXPORT AppCacheUpdateJob
private:
// URLRequest::Delegate overrides
- virtual void OnReceivedRedirect(net::URLRequest* request,
- const net::RedirectInfo& redirect_info,
- bool* defer_redirect) override;
- virtual void OnResponseStarted(net::URLRequest* request) override;
- virtual void OnReadCompleted(net::URLRequest* request,
- int bytes_read) override;
+ void OnReceivedRedirect(net::URLRequest* request,
+ const net::RedirectInfo& redirect_info,
+ bool* defer_redirect) override;
+ void OnResponseStarted(net::URLRequest* request) override;
+ void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
void AddConditionalHeaders(const net::HttpResponseHeaders* headers);
void OnWriteComplete(int result);
@@ -165,23 +164,22 @@ class CONTENT_EXPORT AppCacheUpdateJob
AppCacheResponseWriter* CreateResponseWriter();
// Methods for AppCacheStorage::Delegate.
- virtual void OnResponseInfoLoaded(AppCacheResponseInfo* response_info,
- int64 response_id) override;
- virtual void OnGroupAndNewestCacheStored(AppCacheGroup* group,
- AppCache* newest_cache,
- bool success,
- bool would_exceed_quota) override;
- virtual void OnGroupMadeObsolete(AppCacheGroup* group,
+ void OnResponseInfoLoaded(AppCacheResponseInfo* response_info,
+ int64 response_id) override;
+ void OnGroupAndNewestCacheStored(AppCacheGroup* group,
+ AppCache* newest_cache,
bool success,
- int response_code) override;
+ bool would_exceed_quota) override;
+ void OnGroupMadeObsolete(AppCacheGroup* group,
+ bool success,
+ int response_code) override;
// Methods for AppCacheHost::Observer.
- virtual void OnCacheSelectionComplete(AppCacheHost* host) override {} // N/A
- virtual void OnDestructionImminent(AppCacheHost* host) override;
+ void OnCacheSelectionComplete(AppCacheHost* host) override {} // N/A
+ void OnDestructionImminent(AppCacheHost* host) override;
// Methods for AppCacheServiceImpl::Observer.
- virtual void OnServiceReinitialized(
- AppCacheStorageReference* old_storage) override;
+ void OnServiceReinitialized(AppCacheStorageReference* old_storage) override;
void HandleCacheFailure(const AppCacheErrorDetails& details,
ResultType result,
« no previous file with comments | « content/browser/appcache/appcache_unittest.cc ('k') | content/browser/appcache/appcache_update_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698