Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_internals_ui.cc
diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc
index b0e79a1d7cdcd0a8d3621cb4da05388af3287450..8265292445a47d508a2ba84cfaa6085f82cf6272 100644
--- a/content/browser/service_worker/service_worker_internals_ui.cc
+++ b/content/browser/service_worker/service_worker_internals_ui.cc
@@ -300,11 +300,11 @@ class ServiceWorkerInternalsUI::PartitionObserver
public:
PartitionObserver(int partition_id, WebUI* web_ui)
: partition_id_(partition_id), web_ui_(web_ui) {}
- virtual ~PartitionObserver() {}
+ ~PartitionObserver() override {}
// ServiceWorkerContextObserver overrides:
- virtual void OnWorkerStarted(int64 version_id,
- int process_id,
- int thread_id) override {
+ void OnWorkerStarted(int64 version_id,
+ int process_id,
+ int thread_id) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
web_ui_->CallJavascriptFunction(
"serviceworker.onWorkerStarted",
@@ -313,9 +313,9 @@ class ServiceWorkerInternalsUI::PartitionObserver
FundamentalValue(process_id),
FundamentalValue(thread_id));
}
- virtual void OnWorkerStopped(int64 version_id,
- int process_id,
- int thread_id) override {
+ void OnWorkerStopped(int64 version_id,
+ int process_id,
+ int thread_id) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
web_ui_->CallJavascriptFunction(
"serviceworker.onWorkerStopped",
@@ -324,17 +324,17 @@ class ServiceWorkerInternalsUI::PartitionObserver
FundamentalValue(process_id),
FundamentalValue(thread_id));
}
- virtual void OnVersionStateChanged(int64 version_id) override {
+ void OnVersionStateChanged(int64 version_id) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
web_ui_->CallJavascriptFunction(
"serviceworker.onVersionStateChanged",
FundamentalValue(partition_id_),
StringValue(base::Int64ToString(version_id)));
}
- virtual void OnErrorReported(int64 version_id,
- int process_id,
- int thread_id,
- const ErrorInfo& info) override {
+ void OnErrorReported(int64 version_id,
+ int process_id,
+ int thread_id,
+ const ErrorInfo& info) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
ScopedVector<const Value> args;
args.push_back(new FundamentalValue(partition_id_));
@@ -350,10 +350,10 @@ class ServiceWorkerInternalsUI::PartitionObserver
web_ui_->CallJavascriptFunction("serviceworker.onErrorReported",
args.get());
}
- virtual void OnReportConsoleMessage(int64 version_id,
- int process_id,
- int thread_id,
- const ConsoleMessage& message) override {
+ void OnReportConsoleMessage(int64 version_id,
+ int process_id,
+ int thread_id,
+ const ConsoleMessage& message) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
ScopedVector<const Value> args;
args.push_back(new FundamentalValue(partition_id_));
@@ -370,12 +370,12 @@ class ServiceWorkerInternalsUI::PartitionObserver
web_ui_->CallJavascriptFunction("serviceworker.onConsoleMessageReported",
args.get());
}
- virtual void OnRegistrationStored(const GURL& pattern) override {
+ void OnRegistrationStored(const GURL& pattern) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
web_ui_->CallJavascriptFunction("serviceworker.onRegistrationStored",
StringValue(pattern.spec()));
}
- virtual void OnRegistrationDeleted(const GURL& pattern) override {
+ void OnRegistrationDeleted(const GURL& pattern) override {
web_ui_->CallJavascriptFunction("serviceworker.onRegistrationDeleted",
StringValue(pattern.spec()));
}

Powered by Google App Engine
This is Rietveld 408576698