content/browser/devtools/devtools_tracing_handler.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_tracing_handler.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_tracing_handler.h ('k') | content/browser/devtools/embedded_worker_devtools_agent_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_tracing_handler.cc

diff --git a/content/browser/devtools/devtools_tracing_handler.cc b/content/browser/devtools/devtools_tracing_handler.cc

index 5dce87424cb87eca5e33b7f39fdb8df075e2cddd..f8539da4b067493b188f70fa4fd8344515e4e7f4 100644

--- a/content/browser/devtools/devtools_tracing_handler.cc

+++ b/content/browser/devtools/devtools_tracing_handler.cc

@@ -32,17 +32,17 @@ class DevToolsTraceSinkProxy : public TracingController::TraceDataSink {

explicit DevToolsTraceSinkProxy(base::WeakPtr<DevToolsTracingHandler> handler)

: tracing_handler_(handler) {}

- virtual void AddTraceChunk(const std::string& chunk) override {

+ void AddTraceChunk(const std::string& chunk) override {

if (DevToolsTracingHandler* h = tracing_handler_.get())

h->OnTraceDataCollected(chunk);

}

- virtual void Close() override {

+ void Close() override {

if (DevToolsTracingHandler* h = tracing_handler_.get())

h->OnTraceComplete();

}

private:

- virtual ~DevToolsTraceSinkProxy() {}

+ ~DevToolsTraceSinkProxy() override {}

base::WeakPtr<DevToolsTracingHandler> tracing_handler_;

};