content/browser/battery_status/battery_status_manager_mac.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/battery_status/battery_status_manager_mac.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/battery_status/battery_status_browsertest.cc ('k') | content/browser/battery_status/battery_status_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/battery_status/battery_status_manager_mac.cc

diff --git a/content/browser/battery_status/battery_status_manager_mac.cc b/content/browser/battery_status/battery_status_manager_mac.cc

index 00b53728b8ebb2d2beabe2bd032830aee801f686..761b2717bdd3b2df11169dfb867485250b1939b6 100644

--- a/content/browser/battery_status/battery_status_manager_mac.cc

+++ b/content/browser/battery_status/battery_status_manager_mac.cc

@@ -254,18 +254,16 @@ class BatteryStatusManagerMac : public BatteryStatusManager {

explicit BatteryStatusManagerMac(const BatteryCallback& callback)

: notifier_(new BatteryStatusObserver(callback)) {}

- virtual ~BatteryStatusManagerMac() {

- notifier_->Stop();

- }

+ ~BatteryStatusManagerMac() override { notifier_->Stop(); }

// BatteryStatusManager:

- virtual bool StartListeningBatteryChange() override {

+ bool StartListeningBatteryChange() override {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

notifier_->Start();

return true;

}

- virtual void StopListeningBatteryChange() override {

+ void StopListeningBatteryChange() override {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

notifier_->Stop();

}