content/browser/indexed_db/leveldb/leveldb_transaction.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_iterator_impl.h ('k') | content/browser/indexed_db/leveldb/leveldb_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/leveldb/leveldb_transaction.h

diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.h b/content/browser/indexed_db/leveldb/leveldb_transaction.h

index aec836ef6ee1d402a3560c37d37736928b7da0f2..28d7656937486ebbfb90ca647db13c1129449e98 100644

--- a/content/browser/indexed_db/leveldb/leveldb_transaction.h

+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.h

@@ -71,15 +71,15 @@ class CONTENT_EXPORT LevelDBTransaction

class DataIterator : public LevelDBIterator {

public:

static scoped_ptr<DataIterator> Create(LevelDBTransaction* transaction);

- virtual ~DataIterator();

- virtual bool IsValid() const override;

- virtual leveldb::Status SeekToLast() override;

- virtual leveldb::Status Seek(const base::StringPiece& slice) override;

- virtual leveldb::Status Next() override;

- virtual leveldb::Status Prev() override;

- virtual base::StringPiece Key() const override;

- virtual base::StringPiece Value() const override;

+ ~DataIterator() override;

+ bool IsValid() const override;

+ leveldb::Status SeekToLast() override;

+ leveldb::Status Seek(const base::StringPiece& slice) override;

+ leveldb::Status Next() override;

+ leveldb::Status Prev() override;

+ base::StringPiece Key() const override;

+ base::StringPiece Value() const override;

bool IsDeleted() const;

private:

@@ -92,17 +92,17 @@ class CONTENT_EXPORT LevelDBTransaction

class TransactionIterator : public LevelDBIterator {

public:

- virtual ~TransactionIterator();

+ ~TransactionIterator() override;

static scoped_ptr<TransactionIterator> Create(

scoped_refptr<LevelDBTransaction> transaction);