content/browser/appcache/chrome_appcache_service.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/chrome_appcache_service.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_url_request_job_unittest.cc ('k') | content/browser/appcache/chrome_appcache_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/chrome_appcache_service.h

diff --git a/content/browser/appcache/chrome_appcache_service.h b/content/browser/appcache/chrome_appcache_service.h

index 6ad89315acd5273f3294c8a586909c7b7044047f..6976d873007ac5c926816b94c75554ea8fdbbb6b 100644

--- a/content/browser/appcache/chrome_appcache_service.h

+++ b/content/browser/appcache/chrome_appcache_service.h

@@ -53,13 +53,13 @@ class CONTENT_EXPORT ChromeAppCacheService

scoped_refptr<storage::SpecialStoragePolicy> special_storage_policy);

// AppCachePolicy overrides

- virtual bool CanLoadAppCache(const GURL& manifest_url,

- const GURL& first_party) override;

- virtual bool CanCreateAppCache(const GURL& manifest_url,

- const GURL& first_party) override;

+ bool CanLoadAppCache(const GURL& manifest_url,

+ const GURL& first_party) override;

+ bool CanCreateAppCache(const GURL& manifest_url,

+ const GURL& first_party) override;

protected:

- virtual ~ChromeAppCacheService();

+ ~ChromeAppCacheService() override;

private:

friend class base::DeleteHelper<ChromeAppCacheService>;