Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: content/browser/child_process_security_policy_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_security_policy_impl.h
diff --git a/content/browser/child_process_security_policy_impl.h b/content/browser/child_process_security_policy_impl.h
index d0a172dbdf06b33ff8aeeee66052d95fe002a7e7..dcc1b887fab2dcc5d6476bb0529aa2d4c07ec170 100644
--- a/content/browser/child_process_security_policy_impl.h
+++ b/content/browser/child_process_security_policy_impl.h
@@ -35,52 +35,44 @@ class CONTENT_EXPORT ChildProcessSecurityPolicyImpl
public:
// Object can only be created through GetInstance() so the constructor is
// private.
- virtual ~ChildProcessSecurityPolicyImpl();
+ ~ChildProcessSecurityPolicyImpl() override;
static ChildProcessSecurityPolicyImpl* GetInstance();
// ChildProcessSecurityPolicy implementation.
- virtual void RegisterWebSafeScheme(const std::string& scheme) override;
- virtual bool IsWebSafeScheme(const std::string& scheme) override;
- virtual void GrantReadFile(int child_id, const base::FilePath& file) override;
- virtual void GrantCreateReadWriteFile(int child_id,
- const base::FilePath& file) override;
- virtual void GrantCopyInto(int child_id, const base::FilePath& dir) override;
- virtual void GrantDeleteFrom(int child_id,
- const base::FilePath& dir) override;
- virtual void GrantReadFileSystem(
+ void RegisterWebSafeScheme(const std::string& scheme) override;
+ bool IsWebSafeScheme(const std::string& scheme) override;
+ void GrantReadFile(int child_id, const base::FilePath& file) override;
+ void GrantCreateReadWriteFile(int child_id,
+ const base::FilePath& file) override;
+ void GrantCopyInto(int child_id, const base::FilePath& dir) override;
+ void GrantDeleteFrom(int child_id, const base::FilePath& dir) override;
+ void GrantReadFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ void GrantWriteFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ void GrantCreateFileForFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ void GrantCreateReadWriteFileSystem(
int child_id,
const std::string& filesystem_id) override;
- virtual void GrantWriteFileSystem(
- int child_id,
- const std::string& filesystem_id) override;
- virtual void GrantCreateFileForFileSystem(
- int child_id,
- const std::string& filesystem_id) override;
- virtual void GrantCreateReadWriteFileSystem(
- int child_id,
- const std::string& filesystem_id) override;
- virtual void GrantCopyIntoFileSystem(
- int child_id,
- const std::string& filesystem_id) override;
- virtual void GrantDeleteFromFileSystem(
- int child_id,
- const std::string& filesystem_id) override;
- virtual void GrantScheme(int child_id, const std::string& scheme) override;
- virtual bool CanReadFile(int child_id, const base::FilePath& file) override;
- virtual bool CanCreateReadWriteFile(int child_id,
- const base::FilePath& file) override;
- virtual bool CanReadFileSystem(int child_id,
+ void GrantCopyIntoFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ void GrantDeleteFromFileSystem(int child_id,
const std::string& filesystem_id) override;
- virtual bool CanReadWriteFileSystem(
- int child_id,
- const std::string& filesystem_id) override;
- virtual bool CanCopyIntoFileSystem(int child_id,
- const std::string& filesystem_id) override;
- virtual bool CanDeleteFromFileSystem(
- int child_id,
- const std::string& filesystem_id) override;
- virtual bool HasWebUIBindings(int child_id) override;
+ void GrantScheme(int child_id, const std::string& scheme) override;
+ bool CanReadFile(int child_id, const base::FilePath& file) override;
+ bool CanCreateReadWriteFile(int child_id,
+ const base::FilePath& file) override;
+ bool CanReadFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ bool CanReadWriteFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ bool CanCopyIntoFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ bool CanDeleteFromFileSystem(int child_id,
+ const std::string& filesystem_id) override;
+ bool HasWebUIBindings(int child_id) override;
// Pseudo schemes are treated differently than other schemes because they
// cannot be requested like normal URLs. There is no mechanism for revoking
« no previous file with comments | « content/browser/child_process_launcher_browsertest.cc ('k') | content/browser/child_process_security_policy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698