Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: content/browser/browser_child_process_host_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/bootstrap_sandbox_mac.cc ('k') | content/browser/browser_main_loop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_child_process_host_impl.h
diff --git a/content/browser/browser_child_process_host_impl.h b/content/browser/browser_child_process_host_impl.h
index dcd975c2cc7d769f1249940679a5e1fce2e7c07b..4490b99e1422be34520be4f88297d23b2a93fd6e 100644
--- a/content/browser/browser_child_process_host_impl.h
+++ b/content/browser/browser_child_process_host_impl.h
@@ -45,32 +45,31 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
BrowserChildProcessHostImpl(
int process_type,
BrowserChildProcessHostDelegate* delegate);
- virtual ~BrowserChildProcessHostImpl();
+ ~BrowserChildProcessHostImpl() override;
// Terminates all child processes and deletes each BrowserChildProcessHost
// instance.
static void TerminateAll();
// BrowserChildProcessHost implementation:
- virtual bool Send(IPC::Message* message) override;
- virtual void Launch(
- SandboxedProcessLauncherDelegate* delegate,
- base::CommandLine* cmd_line) override;
- virtual const ChildProcessData& GetData() const override;
- virtual ChildProcessHost* GetHost() const override;
- virtual base::TerminationStatus GetTerminationStatus(
- bool known_dead, int* exit_code) override;
- virtual void SetName(const base::string16& name) override;
- virtual void SetHandle(base::ProcessHandle handle) override;
+ bool Send(IPC::Message* message) override;
+ void Launch(SandboxedProcessLauncherDelegate* delegate,
+ base::CommandLine* cmd_line) override;
+ const ChildProcessData& GetData() const override;
+ ChildProcessHost* GetHost() const override;
+ base::TerminationStatus GetTerminationStatus(bool known_dead,
+ int* exit_code) override;
+ void SetName(const base::string16& name) override;
+ void SetHandle(base::ProcessHandle handle) override;
// ChildProcessHostDelegate implementation:
- virtual bool CanShutdown() override;
- virtual void OnChildDisconnected() override;
- virtual base::ProcessHandle GetHandle() const override;
- virtual bool OnMessageReceived(const IPC::Message& message) override;
- virtual void OnChannelConnected(int32 peer_pid) override;
- virtual void OnChannelError() override;
- virtual void OnBadMessageReceived(const IPC::Message& message) override;
+ bool CanShutdown() override;
+ void OnChildDisconnected() override;
+ base::ProcessHandle GetHandle() const override;
+ bool OnMessageReceived(const IPC::Message& message) override;
+ void OnChannelConnected(int32 peer_pid) override;
+ void OnChannelError() override;
+ void OnBadMessageReceived(const IPC::Message& message) override;
// Removes this host from the host list. Calls ChildProcessHost::ForceShutdown
void ForceShutdown();
@@ -103,8 +102,8 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
static void RemoveObserver(BrowserChildProcessObserver* observer);
// ChildProcessLauncher::Client implementation.
- virtual void OnProcessLaunched() override;
- virtual void OnProcessLaunchFailed() override;
+ void OnProcessLaunched() override;
+ void OnProcessLaunchFailed() override;
#if defined(OS_WIN)
// ObjectWatcher::Delegate implementation.
« no previous file with comments | « content/browser/bootstrap_sandbox_mac.cc ('k') | content/browser/browser_main_loop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698