content/browser/gamepad/gamepad_provider.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gamepad/gamepad_provider.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/gamepad/gamepad_platform_data_fetcher_mac.h ('k') | content/browser/gamepad/gamepad_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gamepad/gamepad_provider.h

diff --git a/content/browser/gamepad/gamepad_provider.h b/content/browser/gamepad/gamepad_provider.h

index 97657c9f9c0d87c26d708a283b5be329d0ef1740..a81061a21f53c03be8251899b48e2b272d8fef75 100644

--- a/content/browser/gamepad/gamepad_provider.h

+++ b/content/browser/gamepad/gamepad_provider.h

@@ -37,7 +37,7 @@ class CONTENT_EXPORT GamepadProvider :

// Manually specifies the data fetcher. Used for testing.

explicit GamepadProvider(scoped_ptr<GamepadDataFetcher> fetcher);

- virtual ~GamepadProvider();

+ ~GamepadProvider() override;

// Returns the shared memory handle of the gamepad data duplicated into the

// given process.

@@ -56,7 +56,7 @@ class CONTENT_EXPORT GamepadProvider :

void RegisterForUserGesture(const base::Closure& closure);

// base::SystemMonitor::DevicesChangedObserver implementation.

- virtual void OnDevicesChanged(base::SystemMonitor::DeviceType type) override;

+ void OnDevicesChanged(base::SystemMonitor::DeviceType type) override;

private:

void Initialize(scoped_ptr<GamepadDataFetcher> fetcher);

« no previous file with comments | « content/browser/gamepad/gamepad_platform_data_fetcher_mac.h ('k') | content/browser/gamepad/gamepad_service_unittest.cc » ('j') | no next file with comments »