Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: content/browser/download/save_file_resource_handler.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/mhtml_generation_manager.cc ('k') | content/browser/download/save_package.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_file_resource_handler.h
diff --git a/content/browser/download/save_file_resource_handler.h b/content/browser/download/save_file_resource_handler.h
index d115b6fa14e1eb95e16fa5cdb1189b72a5644081..b7425b49b01d3cf533b42f89feefaf30ddccc3a8 100644
--- a/content/browser/download/save_file_resource_handler.h
+++ b/content/browser/download/save_file_resource_handler.h
@@ -26,42 +26,41 @@ class SaveFileResourceHandler : public ResourceHandler {
int render_view_id,
const GURL& url,
SaveFileManager* manager);
- virtual ~SaveFileResourceHandler();
+ ~SaveFileResourceHandler() override;
// ResourceHandler Implementation:
- virtual bool OnUploadProgress(uint64 position, uint64 size) override;
+ bool OnUploadProgress(uint64 position, uint64 size) override;
// Saves the redirected URL to final_url_, we need to use the original
// URL to match original request.
- virtual bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
- ResourceResponse* response,
- bool* defer) override;
+ bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
+ ResourceResponse* response,
+ bool* defer) override;
// Sends the download creation information to the download thread.
- virtual bool OnResponseStarted(ResourceResponse* response,
- bool* defer) override;
+ bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
// Pass-through implementation.
- virtual bool OnWillStart(const GURL& url, bool* defer) override;
+ bool OnWillStart(const GURL& url, bool* defer) override;
// Pass-through implementation.
- virtual bool OnBeforeNetworkStart(const GURL& url, bool* defer) override;
+ bool OnBeforeNetworkStart(const GURL& url, bool* defer) override;
// Creates a new buffer, which will be handed to the download thread for file
// writing and deletion.
- virtual bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
- int* buf_size,
- int min_size) override;
+ bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
+ int* buf_size,
+ int min_size) override;
// Passes the buffer to the download file writer.
- virtual bool OnReadCompleted(int bytes_read, bool* defer) override;
+ bool OnReadCompleted(int bytes_read, bool* defer) override;
- virtual void OnResponseCompleted(const net::URLRequestStatus& status,
- const std::string& security_info,
- bool* defer) override;
+ void OnResponseCompleted(const net::URLRequestStatus& status,
+ const std::string& security_info,
+ bool* defer) override;
// N/A to this flavor of SaveFileResourceHandler.
- virtual void OnDataDownloaded(int bytes_downloaded) override;
+ void OnDataDownloaded(int bytes_downloaded) override;
// If the content-length header is not present (or contains something other
// than numbers), StringToInt64 returns 0, which indicates 'unknown size' and
« no previous file with comments | « content/browser/download/mhtml_generation_manager.cc ('k') | content/browser/download/save_package.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698