content/browser/webui/web_ui_data_source_unittest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/web_ui_data_source_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/webui/web_ui_data_source_unittest.cc

diff --git a/content/browser/webui/web_ui_data_source_unittest.cc b/content/browser/webui/web_ui_data_source_unittest.cc

index 07e271ff18eafee579583b919a6d81e951a270ae..60dcb64a2af98297d330b4b0fa8f1473c82a0196 100644

--- a/content/browser/webui/web_ui_data_source_unittest.cc

+++ b/content/browser/webui/web_ui_data_source_unittest.cc

@@ -24,16 +24,16 @@ const char kDummytResource[] = "<html>blah</html>";

class TestClient : public TestContentClient {

public:

TestClient() {}

- virtual ~TestClient() {}

+ ~TestClient() override {}

- virtual base::string16 GetLocalizedString(int message_id) const override {

+ base::string16 GetLocalizedString(int message_id) const override {

if (message_id == kDummyStringId)

return base::UTF8ToUTF16(kDummyString);

return base::string16();

}

- virtual base::RefCountedStaticMemory* GetDataResourceBytes(

+ base::RefCountedStaticMemory* GetDataResourceBytes(

int resource_id) const override {

base::RefCountedStaticMemory* bytes = NULL;

if (resource_id == kDummyDefaultResourceId) {

« no previous file with comments | « content/browser/webui/web_ui_data_source_impl.cc ('k') | content/browser/webui/web_ui_impl.h » ('j') | no next file with comments »