Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6941)

Unified Diff: content/browser/loader/resource_scheduler_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_scheduler_unittest.cc
diff --git a/content/browser/loader/resource_scheduler_unittest.cc b/content/browser/loader/resource_scheduler_unittest.cc
index 5b8ecf6cf062c67b06de98b70e4c34645f7cd4bb..02807b3b2701403bd8d3f4ed0b2dbf146387ef33 100644
--- a/content/browser/loader/resource_scheduler_unittest.cc
+++ b/content/browser/loader/resource_scheduler_unittest.cc
@@ -56,7 +56,7 @@ class TestRequest : public ResourceController {
url_request_(url_request.Pass()) {
throttle_->set_controller_for_testing(this);
}
- virtual ~TestRequest() {}
+ ~TestRequest() override {}
bool started() const { return started_; }
@@ -66,7 +66,7 @@ class TestRequest : public ResourceController {
started_ = !deferred;
}
- virtual void Cancel() override {
+ void Cancel() override {
// Alert the scheduler that the request can be deleted.
throttle_.reset(0);
}
@@ -75,9 +75,9 @@ class TestRequest : public ResourceController {
protected:
// ResourceController interface:
- virtual void CancelAndIgnore() override {}
- virtual void CancelWithError(int error_code) override {}
- virtual void Resume() override { started_ = true; }
+ void CancelAndIgnore() override {}
+ void CancelWithError(int error_code) override {}
+ void Resume() override { started_ = true; }
private:
bool started_;
@@ -96,7 +96,7 @@ class CancelingTestRequest : public TestRequest {
}
private:
- virtual void Resume() override {
+ void Resume() override {
TestRequest::Resume();
request_to_cancel_.reset();
}
@@ -106,8 +106,8 @@ class CancelingTestRequest : public TestRequest {
class FakeResourceContext : public ResourceContext {
private:
- virtual net::HostResolver* GetHostResolver() override { return NULL; }
- virtual net::URLRequestContext* GetRequestContext() override { return NULL; }
+ net::HostResolver* GetHostResolver() override { return NULL; }
+ net::URLRequestContext* GetRequestContext() override { return NULL; }
};
class FakeResourceMessageFilter : public ResourceMessageFilter {
@@ -125,7 +125,7 @@ class FakeResourceMessageFilter : public ResourceMessageFilter {
}
private:
- virtual ~FakeResourceMessageFilter() {}
+ ~FakeResourceMessageFilter() override {}
void GetContexts(const ResourceHostMsg_Request& request,
ResourceContext** resource_context,
« no previous file with comments | « content/browser/loader/resource_scheduler_filter.h ('k') | content/browser/loader/stream_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698