content/browser/dom_storage/local_storage_database_adapter.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/dom_storage/local_storage_database_adapter.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/dom_storage/dom_storage_task_runner.h ('k') | content/browser/dom_storage/session_storage_database_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/dom_storage/local_storage_database_adapter.h

diff --git a/content/browser/dom_storage/local_storage_database_adapter.h b/content/browser/dom_storage/local_storage_database_adapter.h

index c758dd4426d08b96d02567942d6e4167afd1ae38..fca55d0c4e07973ee8a1ec251b316b2ff41f4bc1 100644

--- a/content/browser/dom_storage/local_storage_database_adapter.h

+++ b/content/browser/dom_storage/local_storage_database_adapter.h

@@ -22,12 +22,12 @@ class CONTENT_EXPORT LocalStorageDatabaseAdapter :

public DOMStorageDatabaseAdapter {

public:

explicit LocalStorageDatabaseAdapter(const base::FilePath& path);

- virtual ~LocalStorageDatabaseAdapter();

- virtual void ReadAllValues(DOMStorageValuesMap* result) override;

- virtual bool CommitChanges(bool clear_all_first,

- const DOMStorageValuesMap& changes) override;

- virtual void DeleteFiles() override;

- virtual void Reset() override;

+ ~LocalStorageDatabaseAdapter() override;

+ void ReadAllValues(DOMStorageValuesMap* result) override;

+ bool CommitChanges(bool clear_all_first,

+ const DOMStorageValuesMap& changes) override;

+ void DeleteFiles() override;

+ void Reset() override;

protected:

// Constructor that uses an in-memory sqlite database, for testing.