Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: content/browser/appcache/appcache_host_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_host.h ('k') | content/browser/appcache/appcache_interceptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_host_unittest.cc
diff --git a/content/browser/appcache/appcache_host_unittest.cc b/content/browser/appcache/appcache_host_unittest.cc
index aed32f4cbedb05e37f370054154b82ef32cd869d..817e8c0c924a6f2053e04d7255eb784f01df1930 100644
--- a/content/browser/appcache/appcache_host_unittest.cc
+++ b/content/browser/appcache/appcache_host_unittest.cc
@@ -42,43 +42,39 @@ class AppCacheHostTest : public testing::Test {
content_blocked_(false) {
}
- virtual void OnCacheSelected(
- int host_id, const AppCacheInfo& info) override {
+ void OnCacheSelected(int host_id, const AppCacheInfo& info) override {
last_host_id_ = host_id;
last_cache_id_ = info.cache_id;
last_status_ = info.status;
}
- virtual void OnStatusChanged(const std::vector<int>& host_ids,
- AppCacheStatus status) override {
+ void OnStatusChanged(const std::vector<int>& host_ids,
+ AppCacheStatus status) override {
last_status_changed_ = status;
}
- virtual void OnEventRaised(const std::vector<int>& host_ids,
- AppCacheEventID event_id) override {
+ void OnEventRaised(const std::vector<int>& host_ids,
+ AppCacheEventID event_id) override {
last_event_id_ = event_id;
}
- virtual void OnErrorEventRaised(
- const std::vector<int>& host_ids,
- const AppCacheErrorDetails& details) override {
+ void OnErrorEventRaised(const std::vector<int>& host_ids,
+ const AppCacheErrorDetails& details) override {
last_event_id_ = APPCACHE_ERROR_EVENT;
}
- virtual void OnProgressEventRaised(const std::vector<int>& host_ids,
- const GURL& url,
- int num_total,
- int num_complete) override {
+ void OnProgressEventRaised(const std::vector<int>& host_ids,
+ const GURL& url,
+ int num_total,
+ int num_complete) override {
last_event_id_ = APPCACHE_PROGRESS_EVENT;
}
- virtual void OnLogMessage(int host_id,
- AppCacheLogLevel log_level,
- const std::string& message) override {
- }
+ void OnLogMessage(int host_id,
+ AppCacheLogLevel log_level,
+ const std::string& message) override {}
- virtual void OnContentBlocked(int host_id,
- const GURL& manifest_url) override {
+ void OnContentBlocked(int host_id, const GURL& manifest_url) override {
content_blocked_ = true;
}
@@ -95,29 +91,26 @@ class AppCacheHostTest : public testing::Test {
MockQuotaManagerProxy() : QuotaManagerProxy(NULL, NULL) {}
// Not needed for our tests.
- virtual void RegisterClient(storage::QuotaClient* client) override {}
- virtual void NotifyStorageAccessed(storage::QuotaClient::ID client_id,
- const GURL& origin,
- storage::StorageType type) override {}
- virtual void NotifyStorageModified(storage::QuotaClient::ID client_id,
- const GURL& origin,
- storage::StorageType type,
- int64 delta) override {}
- virtual void SetUsageCacheEnabled(storage::QuotaClient::ID client_id,
- const GURL& origin,
- storage::StorageType type,
- bool enabled) override {}
- virtual void GetUsageAndQuota(
- base::SequencedTaskRunner* original_task_runner,
- const GURL& origin,
- storage::StorageType type,
- const GetUsageAndQuotaCallback& callback) override {}
-
- virtual void NotifyOriginInUse(const GURL& origin) override {
- inuse_[origin] += 1;
- }
-
- virtual void NotifyOriginNoLongerInUse(const GURL& origin) override {
+ void RegisterClient(storage::QuotaClient* client) override {}
+ void NotifyStorageAccessed(storage::QuotaClient::ID client_id,
+ const GURL& origin,
+ storage::StorageType type) override {}
+ void NotifyStorageModified(storage::QuotaClient::ID client_id,
+ const GURL& origin,
+ storage::StorageType type,
+ int64 delta) override {}
+ void SetUsageCacheEnabled(storage::QuotaClient::ID client_id,
+ const GURL& origin,
+ storage::StorageType type,
+ bool enabled) override {}
+ void GetUsageAndQuota(base::SequencedTaskRunner* original_task_runner,
+ const GURL& origin,
+ storage::StorageType type,
+ const GetUsageAndQuotaCallback& callback) override {}
+
+ void NotifyOriginInUse(const GURL& origin) override { inuse_[origin] += 1; }
+
+ void NotifyOriginNoLongerInUse(const GURL& origin) override {
inuse_[origin] -= 1;
}
@@ -133,7 +126,7 @@ class AppCacheHostTest : public testing::Test {
std::map<GURL, int> inuse_;
protected:
- virtual ~MockQuotaManagerProxy() {}
+ ~MockQuotaManagerProxy() override {}
};
void GetStatusCallback(AppCacheStatus status, void* param) {
« no previous file with comments | « content/browser/appcache/appcache_host.h ('k') | content/browser/appcache/appcache_interceptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698