Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/browser/indexed_db/indexed_db_factory_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_factory_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_factory_unittest.cc b/content/browser/indexed_db/indexed_db_factory_unittest.cc
index 141212e704633361c33f1500b9da7d3dfb006979..70f8ae64ad57a18dca100bb198c26fbe45722582 100644
--- a/content/browser/indexed_db/indexed_db_factory_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_factory_unittest.cc
@@ -59,7 +59,7 @@ class MockIDBFactory : public IndexedDBFactoryImpl {
}
private:
- virtual ~MockIDBFactory() {}
+ ~MockIDBFactory() override {}
DISALLOW_COPY_AND_ASSIGN(MockIDBFactory);
};
@@ -204,8 +204,8 @@ class DiskFullFactory : public IndexedDBFactoryImpl {
: IndexedDBFactoryImpl(context) {}
private:
- virtual ~DiskFullFactory() {}
- virtual scoped_refptr<IndexedDBBackingStore> OpenBackingStore(
+ ~DiskFullFactory() override {}
+ scoped_refptr<IndexedDBBackingStore> OpenBackingStore(
const GURL& origin_url,
const base::FilePath& data_directory,
net::URLRequestContext* request_context,
@@ -225,14 +225,14 @@ class LookingForQuotaErrorMockCallbacks : public IndexedDBCallbacks {
public:
LookingForQuotaErrorMockCallbacks()
: IndexedDBCallbacks(NULL, 0, 0), error_called_(false) {}
- virtual void OnError(const IndexedDBDatabaseError& error) override {
+ void OnError(const IndexedDBDatabaseError& error) override {
error_called_ = true;
EXPECT_EQ(blink::WebIDBDatabaseExceptionQuotaError, error.code());
}
bool error_called() const { return error_called_; }
private:
- virtual ~LookingForQuotaErrorMockCallbacks() {}
+ ~LookingForQuotaErrorMockCallbacks() override {}
bool error_called_;
DISALLOW_COPY_AND_ASSIGN(LookingForQuotaErrorMockCallbacks);
@@ -434,13 +434,13 @@ class UpgradeNeededCallbacks : public MockIndexedDBCallbacks {
public:
UpgradeNeededCallbacks() {}
- virtual void OnSuccess(scoped_ptr<IndexedDBConnection> connection,
- const IndexedDBDatabaseMetadata& metadata) override {
+ void OnSuccess(scoped_ptr<IndexedDBConnection> connection,
+ const IndexedDBDatabaseMetadata& metadata) override {
EXPECT_TRUE(connection_.get());
EXPECT_FALSE(connection.get());
}
- virtual void OnUpgradeNeeded(
+ void OnUpgradeNeeded(
int64 old_version,
scoped_ptr<IndexedDBConnection> connection,
const content::IndexedDBDatabaseMetadata& metadata) override {
@@ -448,7 +448,7 @@ class UpgradeNeededCallbacks : public MockIndexedDBCallbacks {
}
protected:
- virtual ~UpgradeNeededCallbacks() {}
+ ~UpgradeNeededCallbacks() override {}
private:
DISALLOW_COPY_AND_ASSIGN(UpgradeNeededCallbacks);
@@ -458,13 +458,13 @@ class ErrorCallbacks : public MockIndexedDBCallbacks {
public:
ErrorCallbacks() : MockIndexedDBCallbacks(false), saw_error_(false) {}
- virtual void OnError(const IndexedDBDatabaseError& error) override {
+ void OnError(const IndexedDBDatabaseError& error) override {
saw_error_= true;
}
bool saw_error() const { return saw_error_; }
private:
- virtual ~ErrorCallbacks() {}
+ ~ErrorCallbacks() override {}
bool saw_error_;
DISALLOW_COPY_AND_ASSIGN(ErrorCallbacks);
« no previous file with comments | « content/browser/indexed_db/indexed_db_factory_impl.h ('k') | content/browser/indexed_db/indexed_db_fake_backing_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698