content/browser/accessibility/browser_accessibility_state_impl.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_state_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_unittest.cc ('k') | content/browser/accessibility/cross_platform_accessibility_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_state_impl.h

diff --git a/content/browser/accessibility/browser_accessibility_state_impl.h b/content/browser/accessibility/browser_accessibility_state_impl.h

index 37dcfadf755730d0b70348ba21ff8ff9b3bf75a7..4c8884373d6c1ef25ed04c62d47369d1ccb310da 100644

--- a/content/browser/accessibility/browser_accessibility_state_impl.h

+++ b/content/browser/accessibility/browser_accessibility_state_impl.h

@@ -40,14 +40,14 @@ class CONTENT_EXPORT BrowserAccessibilityStateImpl

static BrowserAccessibilityStateImpl* GetInstance();

- virtual void EnableAccessibility() override;

- virtual void DisableAccessibility() override;

- virtual void ResetAccessibilityMode() override;

- virtual void OnScreenReaderDetected() override;

- virtual bool IsAccessibleBrowser() override;

- virtual void AddHistogramCallback(base::Closure callback) override;

+ void EnableAccessibility() override;

+ void DisableAccessibility() override;

+ void ResetAccessibilityMode() override;

+ void OnScreenReaderDetected() override;

+ bool IsAccessibleBrowser() override;

+ void AddHistogramCallback(base::Closure callback) override;

- virtual void UpdateHistogramsForTesting() override;

+ void UpdateHistogramsForTesting() override;

AccessibilityMode accessibility_mode() const { return accessibility_mode_; };

@@ -72,7 +72,7 @@ class CONTENT_EXPORT BrowserAccessibilityStateImpl

void UpdateHistograms();

// Leaky singleton, destructor generally won't be called.

- virtual ~BrowserAccessibilityStateImpl();

+ ~BrowserAccessibilityStateImpl() override;

void UpdatePlatformSpecificHistograms();