content/browser/service_worker/service_worker_register_job.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_read_from_cache_job.h ('k') | content/browser/service_worker/service_worker_registration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.h

diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h

index a6e27c11de3ffa32198cd1f5b8dca2377d4fee90..167501b82cff7b333809ac6a218de5bc764bdea2 100644

--- a/content/browser/service_worker/service_worker_register_job.h

+++ b/content/browser/service_worker/service_worker_register_job.h

@@ -51,7 +51,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,

CONTENT_EXPORT ServiceWorkerRegisterJob(

base::WeakPtr<ServiceWorkerContextCore> context,

ServiceWorkerRegistration* registration);

- virtual ~ServiceWorkerRegisterJob();

+ ~ServiceWorkerRegisterJob() override;

// Registers a callback to be called when the promise would resolve (whether

// successfully or not). Multiple callbacks may be registered.

@@ -61,10 +61,10 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,

ServiceWorkerProviderHost* provider_host);

// ServiceWorkerRegisterJobBase implementation:

- virtual void Start() override;

- virtual void Abort() override;

- virtual bool Equals(ServiceWorkerRegisterJobBase* job) override;

- virtual RegistrationJobType GetType() override;

+ void Start() override;

+ void Abort() override;

+ bool Equals(ServiceWorkerRegisterJobBase* job) override;

+ RegistrationJobType GetType() override;

private:

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerProviderHostWaitingVersionTest,

@@ -134,11 +134,11 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,

ServiceWorkerRegistration* registration);

// EmbeddedWorkerInstance::Listener override of OnPausedAfterDownload.

- virtual void OnPausedAfterDownload() override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnPausedAfterDownload() override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// ServiceWorkerRegistration::Listener overrides

- virtual void OnRegistrationFinishedUninstalling(

+ void OnRegistrationFinishedUninstalling(

ServiceWorkerRegistration* registration) override;

void OnCompareScriptResourcesComplete(