content/browser/geolocation/mock_location_provider.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/mock_location_provider.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/mock_location_provider.h ('k') | content/browser/geolocation/network_location_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/mock_location_provider.cc

diff --git a/content/browser/geolocation/mock_location_provider.cc b/content/browser/geolocation/mock_location_provider.cc

index 58d9c43cb41a93f9498c57486d9c30eedc87e8bb..2953ba1be174919df2da917b7ef262da902451ef 100644

--- a/content/browser/geolocation/mock_location_provider.cc

+++ b/content/browser/geolocation/mock_location_provider.cc

@@ -86,7 +86,7 @@ class AutoMockLocationProvider : public MockLocationProvider {

position_.error_code = Geoposition::ERROR_CODE_POSITION_UNAVAILABLE;

}

- virtual bool StartProvider(bool high_accuracy) override {

+ bool StartProvider(bool high_accuracy) override {

MockLocationProvider::StartProvider(high_accuracy);

if (!requires_permission_to_start_) {

UpdateListenersIfNeeded();

@@ -94,7 +94,7 @@ class AutoMockLocationProvider : public MockLocationProvider {

return true;

}

- virtual void OnPermissionGranted() override {

+ void OnPermissionGranted() override {

MockLocationProvider::OnPermissionGranted();

if (requires_permission_to_start_) {

UpdateListenersIfNeeded();

« no previous file with comments | « content/browser/geolocation/mock_location_provider.h ('k') | content/browser/geolocation/network_location_provider.h » ('j') | no next file with comments »