content/browser/renderer_host/media/audio_sync_reader.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_sync_reader.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_renderer_host.cc ('k') | content/browser/renderer_host/media/media_capture_devices_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_sync_reader.h

diff --git a/content/browser/renderer_host/media/audio_sync_reader.h b/content/browser/renderer_host/media/audio_sync_reader.h

index 0a563cdffeca2054a744526c9bb5052f0d6b6393..16af1921894ae94c93bb6c4fd9c963ab0fb4fb0c 100644

--- a/content/browser/renderer_host/media/audio_sync_reader.h

+++ b/content/browser/renderer_host/media/audio_sync_reader.h

@@ -31,12 +31,12 @@ class AudioSyncReader : public media::AudioOutputController::SyncReader {

AudioSyncReader(base::SharedMemory* shared_memory,

const media::AudioParameters& params);

- virtual ~AudioSyncReader();

+ ~AudioSyncReader() override;

// media::AudioOutputController::SyncReader implementations.

- virtual void UpdatePendingBytes(uint32 bytes) override;

- virtual void Read(media::AudioBus* dest) override;

- virtual void Close() override;

+ void UpdatePendingBytes(uint32 bytes) override;

+ void Read(media::AudioBus* dest) override;

+ void Close() override;

bool Init();

bool PrepareForeignSocket(base::ProcessHandle process_handle,