content/browser/devtools/devtools_agent_host_impl.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_sensors/device_orientation_message_filter.h ('k') | content/browser/devtools/devtools_frontend_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_agent_host_impl.h

diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h

index f49e8a07fe4ccb1e63371cbbbc25bfbc5991c702..694590acf1ca25f11a55bbd001ec67eba4c8c15f 100644

--- a/content/browser/devtools/devtools_agent_host_impl.h

+++ b/content/browser/devtools/devtools_agent_host_impl.h

@@ -38,19 +38,19 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {

void Inspect(BrowserContext* browser_context);

// DevToolsAgentHost implementation.

- virtual void AttachClient(DevToolsAgentHostClient* client) override;

- virtual void DetachClient() override;

- virtual bool IsAttached() override;

- virtual void InspectElement(int x, int y) override;

- virtual std::string GetId() override;

- virtual WebContents* GetWebContents() override;

- virtual void DisconnectWebContents() override;

- virtual void ConnectWebContents(WebContents* wc) override;

- virtual bool IsWorker() const override;

+ void AttachClient(DevToolsAgentHostClient* client) override;

+ void DetachClient() override;

+ bool IsAttached() override;

+ void InspectElement(int x, int y) override;

+ std::string GetId() override;

+ WebContents* GetWebContents() override;

+ void DisconnectWebContents() override;

+ void ConnectWebContents(WebContents* wc) override;

+ bool IsWorker() const override;

protected:

DevToolsAgentHostImpl();

- virtual ~DevToolsAgentHostImpl();

+ ~DevToolsAgentHostImpl() override;

void HostClosed();

void SendMessageToClient(const std::string& message);