content/browser/loader/resource_dispatcher_host_browsertest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_browsertest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/redirect_to_file_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_browsertest.cc

diff --git a/content/browser/loader/resource_dispatcher_host_browsertest.cc b/content/browser/loader/resource_dispatcher_host_browsertest.cc

index 5f41e548f7054cc4cfb4a9453e2d3aa094847992..7e2e8b3ccd97c83434e1eb7dda6233650df94977 100644

--- a/content/browser/loader/resource_dispatcher_host_browsertest.cc

+++ b/content/browser/loader/resource_dispatcher_host_browsertest.cc

@@ -36,7 +36,7 @@ class ResourceDispatcherHostBrowserTest : public ContentBrowserTest,

ResourceDispatcherHostBrowserTest() : got_downloads_(false) {}

protected:

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

base::FilePath path = GetTestFilePath("", "");

BrowserThread::PostTask(

BrowserThread::IO,

@@ -50,9 +50,8 @@ class ResourceDispatcherHostBrowserTest : public ContentBrowserTest,

base::Bind(&net::URLRequestFailedJob::AddUrlHandler));

}

- virtual void OnDownloadCreated(

- DownloadManager* manager,

- DownloadItem* item) override {

+ void OnDownloadCreated(DownloadManager* manager,

+ DownloadItem* item) override {

if (!got_downloads_)

got_downloads_ = !!manager->InProgressCount();

}