content/browser/media/capture/web_contents_audio_input_stream.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_audio_input_stream.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/web_contents_audio_input_stream.h ('k') | content/browser/media/capture/web_contents_audio_muter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_audio_input_stream.cc

diff --git a/content/browser/media/capture/web_contents_audio_input_stream.cc b/content/browser/media/capture/web_contents_audio_input_stream.cc

index cdf7eb905fb77c5bdc85b1ea6733ca3913bf3e83..605124dd30848e20e6223c7f143baaa9e8003a0e 100644

--- a/content/browser/media/capture/web_contents_audio_input_stream.cc

+++ b/content/browser/media/capture/web_contents_audio_input_stream.cc

@@ -64,7 +64,7 @@ class WebContentsAudioInputStream::Impl

CLOSED

};

- virtual ~Impl();

+ ~Impl() override;

// Notifies the consumer callback that the stream is now dead.

void ReportError();

@@ -79,12 +79,11 @@ class WebContentsAudioInputStream::Impl

void UnmuteWebContentsAudio();

// AudioMirroringManager::MirroringDestination implementation

- virtual void QueryForMatches(

- const std::set<SourceFrameRef>& candidates,

- const MatchesCallback& results_callback) override;

+ void QueryForMatches(const std::set<SourceFrameRef>& candidates,

+ const MatchesCallback& results_callback) override;

void QueryForMatchesOnUIThread(const std::set<SourceFrameRef>& candidates,

const MatchesCallback& results_callback);

- virtual media::AudioOutputStream* AddInput(

+ media::AudioOutputStream* AddInput(

const media::AudioParameters& params) override;

// Callback which is run when |stream| is closed. Deletes |stream|.