content/browser/shared_worker/shared_worker_service_impl.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/shared_worker/shared_worker_message_filter.h ('k') | content/browser/shared_worker/shared_worker_service_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/shared_worker/shared_worker_service_impl.h

diff --git a/content/browser/shared_worker/shared_worker_service_impl.h b/content/browser/shared_worker/shared_worker_service_impl.h

index 04eb32121e31c571cb28d3fce2a5d7263e523978..b09d58345a9275d4429e5e37a226b6832dbc4fd6 100644

--- a/content/browser/shared_worker/shared_worker_service_impl.h

+++ b/content/browser/shared_worker/shared_worker_service_impl.h

@@ -41,10 +41,10 @@ class CONTENT_EXPORT SharedWorkerServiceImpl

static SharedWorkerServiceImpl* GetInstance();

// WorkerService implementation:

- virtual bool TerminateWorker(int process_id, int route_id) override;

- virtual std::vector<WorkerInfo> GetWorkers() override;

- virtual void AddObserver(WorkerServiceObserver* observer) override;

- virtual void RemoveObserver(WorkerServiceObserver* observer) override;

+ bool TerminateWorker(int process_id, int route_id) override;

+ std::vector<WorkerInfo> GetWorkers() override;

+ void AddObserver(WorkerServiceObserver* observer) override;

+ void RemoveObserver(WorkerServiceObserver* observer) override;

// These methods correspond to worker related IPCs.

void CreateWorker(const ViewHostMsg_CreateWorker_Params& params,

@@ -115,7 +115,7 @@ class CONTENT_EXPORT SharedWorkerServiceImpl

PendingInstaneMap;

SharedWorkerServiceImpl();

- virtual ~SharedWorkerServiceImpl();

+ ~SharedWorkerServiceImpl() override;

void ResetForTesting();