Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_unittest.cc
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc
index 53360c4e6f58e34fe9c4e54c4d99144d944ca6e8..a6fd3b3326f257a7187331019f4a1bc31e210d08 100644
--- a/content/browser/devtools/devtools_http_handler_unittest.cc
+++ b/content/browser/devtools/devtools_http_handler_unittest.cc
@@ -28,25 +28,25 @@ class DummyServerSocket : public net::ServerSocket {
DummyServerSocket() {}
// net::ServerSocket "implementation"
- virtual int Listen(const net::IPEndPoint& address, int backlog) override {
+ int Listen(const net::IPEndPoint& address, int backlog) override {
return net::OK;
}
- virtual int ListenWithAddressAndPort(const std::string& ip_address,
- int port,
- int backlog) override {
+ int ListenWithAddressAndPort(const std::string& ip_address,
+ int port,
+ int backlog) override {
return net::OK;
}
- virtual int GetLocalAddress(net::IPEndPoint* address) const override {
+ int GetLocalAddress(net::IPEndPoint* address) const override {
net::IPAddressNumber number;
EXPECT_TRUE(net::ParseIPLiteralToNumber("127.0.0.1", &number));
*address = net::IPEndPoint(number, kDummyPort);
return net::OK;
}
- virtual int Accept(scoped_ptr<net::StreamSocket>* socket,
- const net::CompletionCallback& callback) override {
+ int Accept(scoped_ptr<net::StreamSocket>* socket,
+ const net::CompletionCallback& callback) override {
return net::ERR_IO_PENDING;
}
};
@@ -60,13 +60,13 @@ class DummyServerSocketFactory
quit_closure_1_(quit_closure_1),
quit_closure_2_(quit_closure_2) {}
- virtual ~DummyServerSocketFactory() {
+ ~DummyServerSocketFactory() override {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE, quit_closure_2_);
}
private:
- virtual scoped_ptr<net::ServerSocket> Create() const override {
+ scoped_ptr<net::ServerSocket> Create() const override {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE, quit_closure_1_);
return scoped_ptr<net::ServerSocket>(new DummyServerSocket());
@@ -78,15 +78,13 @@ class DummyServerSocketFactory
class DummyDelegate : public DevToolsHttpHandlerDelegate {
public:
- virtual std::string GetDiscoveryPageHTML() override { return std::string(); }
+ std::string GetDiscoveryPageHTML() override { return std::string(); }
- virtual bool BundlesFrontendResources() override { return true; }
+ bool BundlesFrontendResources() override { return true; }
- virtual base::FilePath GetDebugFrontendDir() override {
- return base::FilePath();
- }
+ base::FilePath GetDebugFrontendDir() override { return base::FilePath(); }
- virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
+ scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) override {
return scoped_ptr<net::StreamListenSocket>();
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/browser/devtools/devtools_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698