Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_unittest.cc
diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc
index 017a364a3221853a70c87503aa483c8575996682..1389f8da5dad6c1587f9ab0ee9a3f3d5e2cb8a96 100644
--- a/content/browser/renderer_host/render_view_host_unittest.cc
+++ b/content/browser/renderer_host/render_view_host_unittest.cc
@@ -29,9 +29,9 @@ namespace content {
class RenderViewHostTestBrowserClient : public TestContentBrowserClient {
public:
RenderViewHostTestBrowserClient() {}
- virtual ~RenderViewHostTestBrowserClient() {}
+ ~RenderViewHostTestBrowserClient() override {}
- virtual bool IsHandledURL(const GURL& url) override {
+ bool IsHandledURL(const GURL& url) override {
return url.scheme() == url::kFileScheme;
}
@@ -119,18 +119,18 @@ TEST_F(RenderViewHostTest, DontGrantBindingsToSharedProcess) {
class MockDraggingRenderViewHostDelegateView
: public RenderViewHostDelegateView {
public:
- virtual ~MockDraggingRenderViewHostDelegateView() {}
- virtual void StartDragging(const DropData& drop_data,
- blink::WebDragOperationsMask allowed_ops,
- const gfx::ImageSkia& image,
- const gfx::Vector2d& image_offset,
- const DragEventSourceInfo& event_info) override {
+ ~MockDraggingRenderViewHostDelegateView() override {}
+ void StartDragging(const DropData& drop_data,
+ blink::WebDragOperationsMask allowed_ops,
+ const gfx::ImageSkia& image,
+ const gfx::Vector2d& image_offset,
+ const DragEventSourceInfo& event_info) override {
drag_url_ = drop_data.url;
html_base_url_ = drop_data.html_base_url;
}
- virtual void UpdateDragCursor(blink::WebDragOperation operation) override {}
- virtual void GotFocus() override {}
- virtual void TakeFocus(bool reverse) override {}
+ void UpdateDragCursor(blink::WebDragOperation operation) override {}
+ void GotFocus() override {}
+ void TakeFocus(bool reverse) override {}
virtual void UpdatePreferredSize(const gfx::Size& pref_size) {}
GURL drag_url() {
@@ -284,12 +284,12 @@ class TestSaveImageFromDataURL : public RenderMessageFilter {
}
protected:
- virtual ~TestSaveImageFromDataURL() { }
- virtual void DownloadUrl(int render_view_id,
- const GURL& url,
- const Referrer& referrer,
- const base::string16& suggested_name,
- const bool use_prompt) const override {
+ ~TestSaveImageFromDataURL() override {}
+ void DownloadUrl(int render_view_id,
+ const GURL& url,
+ const Referrer& referrer,
+ const base::string16& suggested_name,
+ const bool use_prompt) const override {
url_string_ = url.spec();
is_downloaded_ = true;
}
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698