content/browser/service_worker/service_worker_handle.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_handle.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host_unittest.cc ('k') | content/browser/service_worker/service_worker_internals_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_handle.h

diff --git a/content/browser/service_worker/service_worker_handle.h b/content/browser/service_worker/service_worker_handle.h

index 0ab64a807185f26136440cac283af912d7662075..b769640708973b40dbedeb215be3386d12d5d133 100644

--- a/content/browser/service_worker/service_worker_handle.h

+++ b/content/browser/service_worker/service_worker_handle.h

@@ -49,23 +49,23 @@ class CONTENT_EXPORT ServiceWorkerHandle

int provider_id,

ServiceWorkerRegistration* registration,

ServiceWorkerVersion* version);

- virtual ~ServiceWorkerHandle();

+ ~ServiceWorkerHandle() override;

// ServiceWorkerVersion::Listener overrides.

- virtual void OnWorkerStarted(ServiceWorkerVersion* version) override;

- virtual void OnWorkerStopped(ServiceWorkerVersion* version) override;

- virtual void OnErrorReported(ServiceWorkerVersion* version,

- const base::string16& error_message,

- int line_number,

- int column_number,

- const GURL& source_url) override;

- virtual void OnReportConsoleMessage(ServiceWorkerVersion* version,

- int source_identifier,

- int message_level,

- const base::string16& message,

- int line_number,

- const GURL& source_url) override;

- virtual void OnVersionStateChanged(ServiceWorkerVersion* version) override;

+ void OnWorkerStarted(ServiceWorkerVersion* version) override;

+ void OnWorkerStopped(ServiceWorkerVersion* version) override;

+ void OnErrorReported(ServiceWorkerVersion* version,

+ const base::string16& error_message,

+ int line_number,

+ int column_number,

+ const GURL& source_url) override;

+ void OnReportConsoleMessage(ServiceWorkerVersion* version,

+ int source_identifier,

+ int message_level,

+ const base::string16& message,

+ int line_number,

+ const GURL& source_url) override;

+ void OnVersionStateChanged(ServiceWorkerVersion* version) override;

ServiceWorkerObjectInfo GetObjectInfo();