content/browser/fileapi/upload_file_system_file_element_reader.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/upload_file_system_file_element_reader.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/recursive_operation_delegate_unittest.cc ('k') | content/browser/frame_host/frame_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/upload_file_system_file_element_reader.h

diff --git a/content/browser/fileapi/upload_file_system_file_element_reader.h b/content/browser/fileapi/upload_file_system_file_element_reader.h

index 806473ef442cbcbf35ef3ca9503391c1f9eccdee..bc2a6f7a71a8e266ea78c339b46f36567cf7a8f8 100644

--- a/content/browser/fileapi/upload_file_system_file_element_reader.h

+++ b/content/browser/fileapi/upload_file_system_file_element_reader.h

@@ -31,15 +31,15 @@ class CONTENT_EXPORT UploadFileSystemFileElementReader :

uint64 range_offset,

uint64 range_length,

const base::Time& expected_modification_time);

- virtual ~UploadFileSystemFileElementReader();

+ ~UploadFileSystemFileElementReader() override;

// UploadElementReader overrides:

- virtual int Init(const net::CompletionCallback& callback) override;

- virtual uint64 GetContentLength() const override;

- virtual uint64 BytesRemaining() const override;

- virtual int Read(net::IOBuffer* buf,

- int buf_length,

- const net::CompletionCallback& callback) override;

+ int Init(const net::CompletionCallback& callback) override;

+ uint64 GetContentLength() const override;

+ uint64 BytesRemaining() const override;

+ int Read(net::IOBuffer* buf,

+ int buf_length,

+ const net::CompletionCallback& callback) override;

private:

void OnGetLength(const net::CompletionCallback& callback, int64 result);