content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/browser/renderer_host/render_widget_host_view_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

index ab9c9458bcdd1424e673c1175688bef378e334dd..6ecb6698d52d235fa509897df4b9b96ec2a7c4cd 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm

@@ -72,7 +72,7 @@ bool CheckObjectRespondsToEditCommands(NSArray* edit_commands, id test_obj) {

class MockRenderWidgetHostDelegate : public RenderWidgetHostDelegate {

public:

MockRenderWidgetHostDelegate() {}

- virtual ~MockRenderWidgetHostDelegate() {}

+ ~MockRenderWidgetHostDelegate() override {}

};

// Create a RenderWidget for which we can filter messages.

@@ -86,7 +86,7 @@ class RenderWidgetHostEditCommandCounter : public RenderWidgetHostImpl {

edit_command_message_count_(0) {

}

- virtual bool Send(IPC::Message* message) override {

+ bool Send(IPC::Message* message) override {

if (message->type() == InputMsg_ExecuteEditCommand::ID)

edit_command_message_count_++;

return RenderWidgetHostImpl::Send(message);