content/browser/renderer_host/render_message_filter.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_message_filter.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/quota_reservation_unittest.cc ('k') | content/browser/renderer_host/render_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_message_filter.h

diff --git a/content/browser/renderer_host/render_message_filter.h b/content/browser/renderer_host/render_message_filter.h

index 5aa905481d6166fc37d989ff2432df825d14fe7c..e9e68d0c19e09d372ab872eb2504bbcafa2ab428 100644

--- a/content/browser/renderer_host/render_message_filter.h

+++ b/content/browser/renderer_host/render_message_filter.h

@@ -102,12 +102,12 @@ class CONTENT_EXPORT RenderMessageFilter : public BrowserMessageFilter {

DOMStorageContextWrapper* dom_storage_context);

// IPC::MessageFilter methods:

- virtual void OnChannelClosing() override;

+ void OnChannelClosing() override;

// BrowserMessageFilter methods:

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OnDestruct() const override;

- virtual base::TaskRunner* OverrideTaskRunnerForMessage(

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void OnDestruct() const override;

+ base::TaskRunner* OverrideTaskRunnerForMessage(

const IPC::Message& message) override;

bool OffTheRecord() const;

@@ -120,7 +120,7 @@ class CONTENT_EXPORT RenderMessageFilter : public BrowserMessageFilter {

net::CookieStore* GetCookieStoreForURL(const GURL& url);

protected:

- virtual ~RenderMessageFilter();

+ ~RenderMessageFilter() override;

// This method will be overridden by TestSaveImageFromDataURL class for test.

virtual void DownloadUrl(int render_view_id,