content/browser/renderer_host/render_view_host_browsertest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_browsertest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_browsertest.cc

diff --git a/content/browser/renderer_host/render_view_host_browsertest.cc b/content/browser/renderer_host/render_view_host_browsertest.cc

index db4a21e10aacc72aeda1a365c7b2b3ee6719633c..2fdaf0aa833505080b3a4369c64322b7f0ff3e5d 100644

--- a/content/browser/renderer_host/render_view_host_browsertest.cc

+++ b/content/browser/renderer_host/render_view_host_browsertest.cc

@@ -34,11 +34,10 @@ class RenderViewHostTestWebContentsObserver : public WebContentsObserver {

explicit RenderViewHostTestWebContentsObserver(WebContents* web_contents)

: WebContentsObserver(web_contents),

navigation_count_(0) {}

- virtual ~RenderViewHostTestWebContentsObserver() {}

+ ~RenderViewHostTestWebContentsObserver() override {}

- virtual void DidNavigateMainFrame(

- const LoadCommittedDetails& details,

- const FrameNavigateParams& params) override {

+ void DidNavigateMainFrame(const LoadCommittedDetails& details,

+ const FrameNavigateParams& params) override {

observed_socket_address_ = params.socket_address;

base_url_ = params.base_url;

++navigation_count_;

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »