Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: content/browser/browser_main_runner.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_main_loop.cc ('k') | content/browser/browser_plugin/browser_plugin_embedder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_main_runner.cc
diff --git a/content/browser/browser_main_runner.cc b/content/browser/browser_main_runner.cc
index 5df5d99cd4d4444e1ec6f2086311abfd86f34561..981ed02ba92494b5449b7691dfd779caa40b95ca 100644
--- a/content/browser/browser_main_runner.cc
+++ b/content/browser/browser_main_runner.cc
@@ -134,12 +134,12 @@ class BrowserMainRunnerImpl : public BrowserMainRunner {
BrowserMainRunnerImpl()
: initialization_started_(false), is_shutdown_(false) {}
- virtual ~BrowserMainRunnerImpl() {
+ ~BrowserMainRunnerImpl() override {
if (initialization_started_ && !is_shutdown_)
Shutdown();
}
- virtual int Initialize(const MainFunctionParams& parameters) override {
+ int Initialize(const MainFunctionParams& parameters) override {
TRACE_EVENT0("startup", "BrowserMainRunnerImpl::Initialize");
// On Android we normally initialize the browser in a series of UI thread
// tasks. While this is happening a second request can come from the OS or
@@ -216,14 +216,14 @@ class BrowserMainRunnerImpl : public BrowserMainRunner {
return -1;
}
- virtual int Run() override {
+ int Run() override {
DCHECK(initialization_started_);
DCHECK(!is_shutdown_);
main_loop_->RunMainMessageLoopParts();
return main_loop_->GetResultCode();
}
- virtual void Shutdown() override {
+ void Shutdown() override {
DCHECK(initialization_started_);
DCHECK(!is_shutdown_);
#ifdef LEAK_SANITIZER
« no previous file with comments | « content/browser/browser_main_loop.cc ('k') | content/browser/browser_plugin/browser_plugin_embedder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698