content/browser/geolocation/wifi_data_provider_common_unittest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/wifi_data_provider_common_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/wifi_data_provider_common.h ('k') | content/browser/geolocation/wifi_data_provider_corewlan_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/wifi_data_provider_common_unittest.cc

diff --git a/content/browser/geolocation/wifi_data_provider_common_unittest.cc b/content/browser/geolocation/wifi_data_provider_common_unittest.cc

index 54763a656dfd7dd7abbcc25622c991382f269616..01a6ffb735b928f1e2b9298ba217fbe3e88f852a 100644

--- a/content/browser/geolocation/wifi_data_provider_common_unittest.cc

+++ b/content/browser/geolocation/wifi_data_provider_common_unittest.cc

@@ -84,11 +84,11 @@ class WifiDataProviderCommonWithMock : public WifiDataProviderCommon {

new_polling_policy_(new MockPollingPolicy) {}

// WifiDataProviderCommon

- virtual WlanApiInterface* NewWlanApi() override {

+ WlanApiInterface* NewWlanApi() override {

CHECK(new_wlan_api_ != NULL);

return new_wlan_api_.release();

}

- virtual WifiPollingPolicy* NewPollingPolicy() override {

+ WifiPollingPolicy* NewPollingPolicy() override {

CHECK(new_polling_policy_ != NULL);

return new_polling_policy_.release();

}

@@ -97,7 +97,7 @@ class WifiDataProviderCommonWithMock : public WifiDataProviderCommon {

scoped_ptr<MockPollingPolicy> new_polling_policy_;

private:

- virtual ~WifiDataProviderCommonWithMock() {}

+ ~WifiDataProviderCommonWithMock() override {}

DISALLOW_COPY_AND_ASSIGN(WifiDataProviderCommonWithMock);

};